gulp-ui5-preload icon indicating copy to clipboard operation
gulp-ui5-preload copied to clipboard

Published 20 hours ago • verified publisher icon geekflyer

Generate library-preload.js

Open StErMi opened this issue 8 years ago • 5 comments

I think it could be a good thing to generate a library-preload.js like in grunt-openui5 https://github.com/SAP/grunt-openui5/pull/47

StErMi avatar May 10 '17 09:05 StErMi

Are there any news on this issue? Maybe I could implement this and send a PR?

Kyrodan avatar Nov 02 '17 11:11 Kyrodan

@Kyrodan I'm actually not working on ui5 anymore and hence I'm very open for someone else to become maintainer of this repo (and the npm package). I can give you collaborator rights to the repo if you want.

geekflyer avatar Nov 02 '17 11:11 geekflyer

I fixed the issue in #10.

jomaguma avatar Jun 07 '18 13:06 jomaguma

You can use the SAPUI5 configuration option xx-libraryPreloadFiles to prevent the default request to library-preload.js and make SAPUI5 load the .json file instead. Will be looking into your pull request as soon as possible.

cschuff avatar Jun 12 '18 06:06 cschuff

Thanks for the link, didn't know about that option. However, I'd like to use the .js files instead since it's the default in newer versions. I've been invited to contribute and could merge myself now, but I'll leave the PR open for your review.

jomaguma avatar Jun 12 '18 13:06 jomaguma