George Brighton
George Brighton
Thanks for digging into this! Failing presence pong and channel auth capabilities is fairly fundamental. This is prior to session establishment and so any kind of encryption. It should be...
Nice work! A PR would be fantastic. 1. Let's only allow a 16th pad byte and not accept all the way up to `0xff`. AES in CBC mode normally requires...
[`ipmi_sdr_read_sensor_value()`](https://github.com/ipmitool/ipmitool/blob/master/lib/ipmi_sdr.c#L1581-L1587) appears to treat the bytes more like ASCII than UTF-8 (num bytes == num chars). How about we follow OpenIPMI and decode `StringEncodingUnicode` as `StringEncoding8BitAsciiLatin1`? Some users of the...
> The decoding error happens [here](https://github.com/gebn/bmc/blob/0b0a4acee039ea3658d896565e61f9f474982f30/pkg/ipmi/get_sdr.go#L88). Strange - the Get SDR response should always contain the next RecordID, even if the requested SDR is too long for the BMC to...
> it's returning 0xcc ("Invalid data field in Request") Assuming you have a support contract, it would be worth asking the vendor what they are expecting, as we are sending...
1 and 2 will need more work. 3 sounds fixable, but can I clarify: `RetrieveSupportedCipherSuites()` is by definition a sessionless operation; is it that you're getting the RAKP2 HMAC fail...
The `ipmitool` output for both would be interesting, however I'm not sure `1` is the correct channel value. Does it accept channel 14 (present interface)? The first response breaks the...
Not currently, as I only needed SDR Type 0x1 (Full Sensor Record), which is defined in 43.1 [here](https://www.intel.com/content/dam/www/public/us/en/documents/specification-updates/ipmi-intelligent-platform-mgt-interface-spec-2nd-gen-v2-0-spec-update.pdf#page551). Discrete sensors are likely each represented by an SDR Type 0x2 (Compact...
Is there a binary release of tempo-cli anywhere? I'd like to help, but unfortunately I can't compile this due to AGPL.
Thanks @joe-elliott . I've deployed this with a target group size of 10MB, and upgraded to 2.2.3 at the same time. I'll keep an eye on our ingesters.