bmc_exporter icon indicating copy to clipboard operation
bmc_exporter copied to clipboard

Gracefully handle BMCs returning "Insufficient resources"

Open gebn opened this issue 6 years ago • 1 comments

https://github.com/gebn/bmc_exporter/blob/6275ae241de50a72daf37455c9250e81482a5073/collector/collector.go#L376

If we decode the command response successfully, we don't need to tear down the session, even if the completion code is non-normal, as the session is still in a good state. We will want to retry in the case of insufficient resources, otherwise return the error up, as we can't move past it. Doing this will invalidate this comment:

https://github.com/gebn/bmc_exporter/blob/6275ae241de50a72daf37455c9250e81482a5073/collector/collector.go#L249

Perhaps modify that function to keep returning early iff the context has expired.

gebn avatar Sep 22 '19 17:09 gebn

Test this - overwhelm a BMC such that it returns a non-normal completion code.

gebn avatar Oct 07 '19 00:10 gebn