gear icon indicating copy to clipboard operation
gear copied to clipboard

`ethexe`: emitting an event for ValueClaimed when value == 0 is confusing

Open jekennedy opened this issue 1 year ago • 0 comments

Problem to Solve

In ethexe/contracts/src/Mirror.sol, the function valueClaimed attempts to transfer tokens to a given destination. If value == 0, no transfer happens, but the function still emits the event ValueClaimed.

Possible Solution

If value is 0, emit a different event. Like ValueClaimAttempted.

Notes

No response

jekennedy avatar Aug 22 '24 09:08 jekennedy