geany-themes icon indicating copy to clipboard operation
geany-themes copied to clipboard

Metallic Bottle: use a slightly darker background color for selections

Open eht16 opened this issue 11 months ago • 5 comments

I just made the background color for selections a little darker so that it is different from the foreground color.

Closes #70.

Screenshot

eht16 avatar Mar 03 '24 15:03 eht16

If there are no objections or improvement suggestions, I would like to merge to this in a week.

eht16 avatar Mar 28 '24 08:03 eht16

I think the gray strings are a bit hard to read on that brown, but I have no opinion apart that the mentioned bug is indeed bad, and if this fixes it, good :)

b4n avatar Mar 29 '24 20:03 b4n

@b4n they are indeed. I gave #e4d3c7 it try as a rather lighter brown than before. Screenshot_2024-05-20_17-12-06

This might be better for selection background. Though this makes the braces and the ... in the varags of the function definition harder to read.

I'm really bad at colors :(.

@rovf since you reported it and obviously are using this theme, do you have any preference or a better alternative?

eht16 avatar May 20 '24 15:05 eht16

Better, but what about #ebdfd8? metallic-bottle-ebdfd8

Still not great for readability, but a tad better and the whole theme doesn't focus on contrast it seems.

Not that I care, it's indeed better to get input from actual theme users :slightly_smiling_face:

b4n avatar May 20 '24 20:05 b4n

#ebdfd8 seems fine to me.

Let's see what @rovf says.

eht16 avatar May 20 '24 21:05 eht16