geany-plugins icon indicating copy to clipboard operation
geany-plugins copied to clipboard
verified publisher icon geany

Pair Tag Highlighter - Added a color preferences dialog (Issue #545)

Open PatrickGMM opened this issue 5 years ago • 4 comments

Added a preferences dialog that allows the highlight colors and overall color alpha to be changed.

  • Settings are kept in a .conf file
  • Tested on linux mint 19.1 cinnamon, geany 1.35 with gtk2 v2.24 and gtk3 v3.22

PatrickGMM avatar Jan 06 '20 00:01 PatrickGMM

Afraid the CI fail is pair tag highligher.

Also probably good to follow the style of the original code eg f() not f () but this being a plugin its up to the maintainer to enforce (or not :).

elextr avatar Jan 06 '20 01:01 elextr

strtol() requires including stdlib.h, but you could also use one of the GDK functions such as gdk_rgba_parse() to parse the colour string or expose one of the functions already in Geany to the plugin API and use that.

codebrainz avatar Jan 06 '20 04:01 codebrainz

I see this is pending fixes. Can someone let me know what fixes I need to perform?

PatrickGMM avatar Feb 18 '21 02:02 PatrickGMM

@PatrickGMM as a minimum the PR has conflicts and is not mergable as is, not sure what other fixes, but I guess the plugin maintainer should comment too.

elextr avatar Feb 18 '21 02:02 elextr