geany
Add --library=gtk to cppcheck
Recent versions of cppcheck (2.9+) seem to require this configuration. The gtk.cfg configuration file is part of cppcheck itself.
Closes #1196.
Needs another free here
Interesting. cppcheck 2.9 doesn't find this on my machine. The CI job uses a much older cppcheck version. This is confusing. Anyway, I'm going to fix it.
EDIT: the CI job uses cppcheck 1.82.
cppcheck 2.9 doesn't find this on my machine. EDIT: the CI job uses cppcheck 1.82.
Interesting, wonder why your machine doesn't find it (worries what else it misses)
[Edit: and now the geanyctags error is found in CI with 1.82, maybe we should have had gtk all along?]
@elextr @techee @kugel- anyone for review? I guess we all agree that we want a succeeding CI again :).
I just went through the patch and it seems OK to me except the minor comment above. (I'm not the right person to review anything related to autoconf/automake but I'd say if it works, it's alright)
LGBcusoryI and CI passes, so I would say merge it (since CI is already broken, it can't make it worse :-) and trigger all PRs to re-CI and see what happens.
Thanks for the review. I commented on @techee's comment. If you agree, we could merge it then in a few days.