gamemasterdice icon indicating copy to clipboard operation
gamemasterdice copied to clipboard

Changed theme to material design and other minor changes

Open ghost opened this issue 10 years ago • 2 comments

Hi,

i used your app since a while (for DSA playing), but I didn't like the design, so I changed it. If you like to merge, do it.

Greetings scoute-dich

ghost avatar Nov 06 '15 19:11 ghost

Hi scoute-dich.

thank you for the work, I'm actually interested in a material design update, as well as in making the number of dice dynamic based on the screen width / orientation.

Unfortunately, I can not merge your changes as your first commit is essentially a full-repo-mixup; you have changed the directory structure, added your compiled binaries and more. If you wish the feature to be committed, please refactor it in a way where one commit corresponds to one logical change that can be reviewed.

Thanks very much,

Georg

ge0rg avatar Nov 08 '15 12:11 ge0rg

Hi Georg,

I'm relatively new here. This is my second pullrequest. I think it's to complicated for me to get the things done in a way that you can use them. I think it is easier to close the request. Anyway I can describe what I have done, if you want.

You said that you've already plans for a material design update and new features. And I think you have much more skills in developing than I have. Anyway, if you have further questions ask me. I'm willing to learn.

So excuse the trouble.

Best wishes and I'm looking forward to future updates of your app.

Greetings from germany scoute-dich

ghost avatar Nov 10 '15 17:11 ghost