easy-xmpp-invitation icon indicating copy to clipboard operation
easy-xmpp-invitation copied to clipboard

Adopt a build system

Open strugee opened this issue 7 years ago • 4 comments

As I was authoring #2 I was thinking it'd be nice to have a build system. This would let us do things like uglification, compilation from ES6, maintain the HTML in a nicer-looking language like Pug, etc. However I didn't want to introduce a change that big without approval.

Thoughts?

strugee avatar Jan 30 '17 19:01 strugee

I'm not a "modern" "web developer", so consider me conservative. I'm okay with using a build system, a templating engine and whatever else might help, under two conditions:

  • it doesn't bloat our "binary" (we are at 11KB total payload now! :D )
  • it won't disappear in the next two years (seems to be common with web tools)

ge0rg avatar Jan 30 '17 20:01 ge0rg

@ge0rg OK, good to know. Most of that weight is probably coming from Bootstrap, which is close to being gone (see #1). A build system will let us do minification, which will further improve download size.

strugee avatar Jan 30 '17 21:01 strugee

I suppose that 11KB is already a huge win, compared to "modern" web sites. It doesn't look like we'll get that reduced significantly, so I don't see this argument as the most urgent one.

I've pulled in #2 and I'd like to see #1 handled next, but it's not a blocker for integrating a build system. If you have a specific one to suggest, please do so.

ge0rg avatar Feb 03 '17 11:02 ge0rg

I personally like gulp. It's fast and Unixy.

strugee avatar Feb 03 '17 13:02 strugee