gplugins icon indicating copy to clipboard operation
gplugins copied to clipboard

Interconnect plugin assumes netlist to be omegaconf or something similar instead of dict

Open nikosavola opened this issue 2 years ago • 3 comments

Describe the bug In the interconnect plugin, we seem to assume the netlist structure is something else than what it really is. At least to me netlist seems to be just a dict for which these attributes don't exist.

These lines try to access .x and .y which don't exist https://github.com/gdsfactory/gplugins/blob/4d9459df5fc96a89c1ad9cc8967d4f3389a974a6/gplugins/lumerical/interconnect.py#L173-L176

This appears something that would be catched with gdsfactory/gdsfactory#2080 easily.

nikosavola avatar Nov 15 '23 23:11 nikosavola

Same for the line here

https://github.com/gdsfactory/gplugins/blob/4d9459df5fc96a89c1ad9cc8967d4f3389a974a6/gplugins/lumerical/interconnect.py#L84

nikosavola avatar Nov 15 '23 23:11 nikosavola

yes, it would be great to add some tests for it

@thomasdorch

joamatab avatar Dec 05 '23 18:12 joamatab

This issue is stale because it has been inactive for 60 days. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] avatar Feb 04 '24 12:02 github-actions[bot]