parse Ellipse extrusionDirection

Open FishOrBear opened this issue 3 years ago • 4 comments

Mar 29 '22 14:03 FishOrBear

210 220 230 is generic, maybe we should optimize the code.

Mar 29 '22 15:03 FishOrBear

This should use helpers.parsePoint(scanner) . You can see an example of it in use here: https://github.com/gdsestimating/dxf-parser/blob/a7aef87d70fa9664942beb581fbe791f1360bcf8/src/entities/dimension.ts#L33-L35

Jun 08 '22 03:06 camnewnham

I know this, but there seem to be two ways of handling this 210 in this library, should we unify the code?

Jun 08 '22 06:06 FishOrBear

Any new code should really parse such coordinates into a point object. The 3 extrusionDirection properties were left over from an early iteration of the project and I didn't want to introduce a breaking change.

Jun 25 '22 18:06 bzuillsmith