book icon indicating copy to clipboard operation
book copied to clipboard

CHAPTER: Weights

Open darribas opened this issue 6 years ago • 5 comments

Thread to discuss chapter on Spatial Weights. It picks discussion up from gds#40.

darribas avatar Jun 30 '19 11:06 darribas

Final pass:

  • [x] Dani
  • [ ] Serge
  • [x] Levi

darribas avatar Jun 23 '21 13:06 darribas

Dani final pass tracker, to be edited as we go along:

Things to ensure (from #152 ):

  • [x] Library imports (first time inline, afterwards at the top of the chapter
  • [x] No aliases on imports (import pandas)
  • [x] Ensure no XXX for citations
  • [ ] Ensure matplotlib RC file is picked up and figures are standard
  • [x] Remove %matplotlib inline
  • [x] Graphics
    • No style
    • No title (unless multi-axis titles, but not suptitle)
    • No axes for maps (ax.set_axis_off())
  • [x] Code comments are fine if needed
  • [x] Hide/remove code cells that we want to hide (see docs here)
  • [x] Typesetting check
  • [x] General flow of the text
  • [ ] Ensure there is a "next step" section at the end of the chapter pointing to further references for the topic (re. #137)

darribas avatar Jun 23 '21 13:06 darribas

Notes from my review (to be updated as I go along):

  • I've streamlined the visualisation section because I though there was too much repetition and not enough content (I've added KNN to the figure for completion)
  • My sense is that the use case with boundaries is well above the level of the book, both conceptually and technically. There are snippets I struggle to read through... But I think it's interesting enough it's worth leaving in. I've added a sentence at the beginning signposting this so readers don't freak out.

darribas avatar Jul 09 '21 15:07 darribas

Edits from @darribas ready at #182, ready to merge by @sjsrey / @ljwolf

darribas avatar Jul 09 '21 16:07 darribas

For Further Reading:

2 chapters Anselin and Rey

https://onlinelibrary.wiley.com/doi/10.1111/tesg.12480

sjsrey avatar Sep 17 '21 15:09 sjsrey