godot-open-rpg
godot-open-rpg copied to clipboard
gdquest-demos
Mana preview
Created a small arrow which will point along the mana bar to indicate the amount of mana a skill will use. This is accomplished via a series of signals between the circular menu and the manabar.
There are many more updated files than I'd expected, I believe due to godot's processing/compilation processes. If there is a way to avoid such noisy pull requests to simplify the reviewer's job please let me know.
Appreciate any/all feedback.
You shouldn't remove the *.import files, they're important. Then, when you stage files in git, you shouldn't do git add * unless you checked with git status that you do want them all.
You'll have to go edit your commit, with e.g. git rebase -i HEAD^ (rebase interactively up until one commit before the current one the head is pointing to, generally the last commit). This allows you to edit commits, remove staged files.
If you're having trouble with the git rebase, we can have a call on discord and I can guide you.
Thank you for the feedback, apologies that first attempt was rather messy with so many files. Rebased and cleaned up, hopefully easier to work through now.
Made changes based on feedback as well as topics discussed in the guidelines linked.
Thanks for the improvements. You don't have to comment on every change, github will mark review points as outdated once you change the corresponding lines.
Open RPG is getting a Godot 4 rewrite, closing because of this. See https://github.com/GDQuest/godot-open-rpg/pull/209
Thanks for your work!