Szikszai Gusztáv
Szikszai Gusztáv
In my opinion type aliases adds some complexity when reading code (that's why I didn't implemented it yet) but you're not the first person asking for it, so it will...
First of all thank you very much for this! :pray: It's the biggest feature PR yet! :tada: Since there are many files changed, and also I need to fully understand...
Sorry for taking this long to check this, will do in the next couple of days, and it will definitely be part of the next release!
I've taken a deeper look mostly on the mapping side, I've played around with adding `Codegen.source_mapped` to some places and it added a lot of break points to the debugger....
Rebased from master and tested the build times of https://github.com/mint-lang/mint-ui-website (27K LOC) and it slows down compiling considerably: `source-maps` branch: ``` mint-dev build 25,12s user 0,20s system 104% cpu 24,136...
The culprit seems to be the [IndentedStringBuilder](https://github.com/Namek/mint/blob/source-maps/src/utils/indented_string_builder.cr) using `String.build` instead the build times return to normal. @Namek any idea why it could be slow?
> Where exactly did you replace using String.build? Didn't the test fail? I didn't run the tests, just wanted to find what slows it down :joy: > I picked 16k...
> Are those three the most important, or should we add all possible `` attributes? Yes we can add other attributes as well, it might come in handy for some...
> We currently [raise an issue](https://github.com/mint-lang/mint/blob/master/src/type_checkers/directives/svg.cr?rgh-link-date=2020-09-21T12%3A21%3A21Z#L39-L41), when the `width`, `height`, `viewBox` attributes are not defined on the SVG, is this required? With the current implementation yes they are required [because...
I'm not sure what changes are requested here. The `format` only returns `1` if there is an error while formatting, this for example returns `0` for valid input: ``` ➜...