Gilles DOFFE
Gilles DOFFE
> Great, let's go with this. > > The failing test appears to expose an issue with the si1133 driver (missing includes), can you fix that in passing? done :crossed_fingers:
> Seems you've found a particular whack-a-mole of missing includes for macros (now `drivers/include/hm330x.h` relies on someone else to import its IS_USED); could you fix one more? yeah dont worry,...
@maribu thx, good start but it cannot be changed by command line and it was the ball of whool :sweat_smile: . Fixed it, it builds in native(64) and original board....
@chrysn more than 30 fixes to pass murdock test. More than expected :sweat_smile: . My concerns about these fixes: - size_t real size vary according to architecture, so when size_t...
> On size_t printing, there is "%zu"; did you try whether that works in our case? Seems the good way, indeed. :wink: All seems ok now.
> `%zu` ia not supported by newlib, sadly ... Indeed, `--enable-newlib-io-c99-formats` is not set by default. :thinking: Weird it builds however... What should we do around this ?
Thx @chrysn @maribu . I think we are good now. I tested with native, native64 and on nucleo-g431rb with this small diff: ```diff diff --git a/examples/hello-world/main.c b/examples/hello-world/main.c index 213128ac64..e25fb9ee74 100644...
@chrysn are we good to merge this PR ?
> @chrysn are we good to merge this PR ? small up, no pressure. :wink:
> Update: Feel free to squash at will. Thx for review. I'm not a fan of big squash but I could squash per file it is ok for you @maribu...