panoramic-depth-estimation icon indicating copy to clipboard operation
panoramic-depth-estimation copied to clipboard

Some problems about function.

Open yuniw18 opened this issue 4 years ago • 1 comments

I think

    def generate_image_left(self, img, disp):
        if self.params.equirectangular_mode:
            return bilinear_sampler_equirectangular(img, -disp, self.params.fov)
        else:
            return bilinear_sampler_1d_h(img, -disp, self.params.fov)
    def generate_image_right(self, img, disp):
        if self.params.equirectangular_mode:
            return bilinear_sampler_equirectangular(img, disp)
        else:
            return bilinear_sampler_1d_h(img, disp)

should be

    def generate_image_left(self, img, disp):
        if self.params.equirectangular_mode:
            return bilinear_sampler_equirectangular(img, -disp, self.params.fov)
        else:
            return bilinear_sampler_1d_h(img, -disp)
    def generate_image_right(self, img, disp):
        if self.params.equirectangular_mode:
            return bilinear_sampler_equirectangular(img, disp, self.params.fov)
        else:
            return bilinear_sampler_1d_h(img, disp)

Thank you.

yuniw18 avatar Jun 12 '20 04:06 yuniw18

Hi @yuniw18 I haven’t had time to have a close look but what you say sounds right. Sorry about that.

gdlg avatar Jun 14 '20 14:06 gdlg