vimium-c icon indicating copy to clipboard operation
vimium-c copied to clipboard

Not disabling on iframes of sites that match disabled rules

Open yang opened this issue 3 years ago • 5 comments

I added a site to the disabled rules, but the extension is still running on iframes. Is there a way to prevent this from happening? Thanks for the great extension.

yang avatar Aug 22 '22 18:08 yang

It's designed to do so. Therefore, you need to add exclusion rules for those 3rd-party iframes, too.

You may click an iframe's content, and click Vimium C icon, and then Vimium C's popup dialog will auto predict an exclusion rule whose pattern is the iframe URL.

gdh1995 avatar Aug 23 '22 02:08 gdh1995

If you are open to adding an option for this, I can look into contributing it

yang avatar Aug 23 '22 23:08 yang

(Fyi, my use case is a web application that has many different origins as iframe content. It is tedious to add every individual sites to the exception list.)

yang avatar Aug 23 '22 23:08 yang

Then I wonder why all frames of those origins are not suitable to run Vimium C commands. In theory, pages from different (top-level) origins can not visit each other's JS world, so they should not have any consistent shortcut module?

If those origins belong to a same top-level origin, then exclusion patterns support RegExp and should be able to match them.

gdh1995 avatar Aug 24 '22 01:08 gdh1995

Yeah, they don't belong to the same TLD. They communicates cooperatively using for instance postMessage. They interact poorly with Vimium because the outer application is a complex web page editor, and Vimium interferes with various keyboard operations.

yang avatar Aug 24 '22 16:08 yang