vimium-c icon indicating copy to clipboard operation
vimium-c copied to clipboard

Vomnibar.activateTabSelection: Add filter current group and by group name options

Open tinywrkb opened this issue 3 years ago • 7 comments

The Vomnibar tabs selection mode is very handy is when working in fullscreen mode.
I think it could be even better if there was an option to only list tabs from the current active tabs group.
I looked in front/vomnibar.ts and I didn't find anything relevant.

Another suggestion, which I'm not even sure if it's possible to implement, is to filter tabs by group name.

The user will set a couple of group names in the mapping like this:

# tabs from current window
map t Vomnibar.activateTabSelection currentWindow 

# tabs from current group
map Tg Vomnibar.activateTabSelection group 

# tabs from "Reading" group
map Tr Vomnibar.activateTabSelection group="Reading"

# tabs from "Social" group
map Ts Vomnibar.activateTabSelection group="Social"

...

tinywrkb avatar Jun 26 '22 11:06 tinywrkb

Up to now there's no filter in Vomnibar to only show tabs in a same group.

Detailed logic about tab matching is in https://github.com/gdh1995/vimium-c/blob/8a2c08f3b1be24b0f41d497d126701f48c9d802d/background/completion.ts#L464 .

Browsers like Chrome and Firefox doesn't allow extensions to access group names, unless an extension is upgraded into "Manifest V3". So, because Vimium C is still in Manifest V2, the new feature is impossible to implement.

There has been a plan to upgrade Vimium C to Manifest V3 in up to 1 year. But I have no enough rest time to perfectly do such big changes.

gdh1995 avatar Jun 26 '22 17:06 gdh1995

As for the 1st point, I'll add a feature, so that when a query contains a word of :group, and a current tab has been in a group, Vimium C will only show tabs in a same group (In Manifest V2 extensions are allowed to access group IDs).

gdh1995 avatar Jun 26 '22 17:06 gdh1995

add :group for #671

Amazing! Looking forward to the next release. Thanks!

tinywrkb avatar Jun 26 '22 20:06 tinywrkb

Considering that this is in the manifest-v3, I updated the title here to also mention the group name.

tinywrkb avatar Jun 29 '22 17:06 tinywrkb

Hello, v1.99.0 supports the :group filter, and it has been available on Chrome and Firefox, while the version for MS Edge is waiting for reviews.

gdh1995 avatar Aug 11 '22 04:08 gdh1995

The Edge extension was updated today, and after a quick trial and error, the only way I found to map the :group filter is using the url option like the following.

map Tg Vomnibar.activateTabSelection url=":group"

tinywrkb avatar Aug 27 '22 11:08 tinywrkb

Um yes :group needs to be a part of query words. Sorry I forgot to mention it.

The "tab" completion engine uses ": + xxx" in query as special filters, including :audio (aka :audible), :muted, :unmuted, :incognito, :normal, :pinned, and :group.

gdh1995 avatar Aug 28 '22 03:08 gdh1995