vimium-c icon indicating copy to clipboard operation
vimium-c copied to clipboard

find mode in vimium c pdf extension

Open Craigdreams opened this issue 2 years ago • 1 comments

Describe the bug

-when using find mode in vimium c pdf extension, find does not find all possible occurrences of a word. To determine this i used the browser's find function and compared the word count to with vimiums find mode word count.

-in pdf find mode will not find a multi word search if the multiple words start on one line and end in a new line. this is especially troublesome in regex find mode. since using ".*" will only match strings in a single line rather than strings spanning multiple lines.

legalAspectsOfRealEstate.pdf

To Reproduce using a many paged pdf textbook. use attached pdf to examine these issues, and compatible vimium c pdf extension

Browser, OS and Vimium C versions

  • Browser name: chrome
  • Browser version: Version 118.0.5993.124 (Official Build) (64-bit)
  • Vimium C version: Version 1.99.99
  • vimium C compatible PDF extension version: Version 2.15.349
  • OS name and version: chrome os Version 118.0.5993.124 (Official Build) (64-bit)

Craigdreams avatar Nov 10 '23 20:11 Craigdreams

Sorry but this is impossible to fix this behavior in such a "small" web-extension like Vimium C.

The root cause of your issue is:

  1. in PDF file, there're only "blocks of text", and every "line" which you see may include 1 or more blocks
  2. as a result, there's no reliable way to detect whether a line and a below line belong to a same paragraph
  3. I guess Chrome has implemented a very big and complicated function to improve its search effects
  4. but Vimium C, as a JavaScript-implemented web-extension, can not access the function

gdh1995 avatar Nov 12 '23 14:11 gdh1995