vimium-c-helpers icon indicating copy to clipboard operation
vimium-c-helpers copied to clipboard

Issue with creating marks and going to a mark on PDF Viewer

Open jansenmtan opened this issue 2 years ago • 1 comments

Marks.activateCreate and Marks.activate don't work on the PDF Viewer. For example, pressing "m" does Marks.activateCreate, but pressing any other key will not register to create a mark at that key. Same for Marks.activate. Vimium C version is 1.99.5.

There are two frames in the PDF Viewer. The first frame has the URL pattern file://.* and allows creating marks, but doesn't allow interacting with the PDF Viewer. The other frame has the URL pattern chrome-extension://.* and allows interaction with the PDF Viewer, but doesn't allow the creation of marks.

jansenmtan avatar Nov 17 '22 17:11 jansenmtan

Um it seems v1.99.5 made a wrong change about Marks. To bypass this mistake, you may enable and then disable Prefer keeping URLs in the address bar unchanged on PDF Viewer's options panel:

image

This issue is related about such bugs:

  1. Vimium C v1.99.5 refuses to set local marks of iframes by default (can still work in iframes if with frame parameter)
  2. PDF Viewer for Vimium C's default state of Prefer keeping URLs ... is different from the one enabled and then disabled
  3. Vimium C v1.99.5 doesn't follow stored scrolling position in global marks

gdh1995 avatar Nov 18 '22 02:11 gdh1995