frisbee icon indicating copy to clipboard operation
frisbee copied to clipboard

Use empty layout of pages for displaying error/alert messages

Open PareshMayani opened this issue 9 years ago • 12 comments

As discussed in https://github.com/gdg-x/frisbee/issues/365#issuecomment-123570183 and as of the current scenario, user is not able to proceed further if any error occurs and app becomes unusable, we are just displaying Crouton message (or would be snackbar).

A better pattern suggested by Taylor Ling is to display error messages in empty layout of the pages but with RETRY button so user can at least have a chance to retry if he/she wants.

PareshMayani avatar Jul 22 '15 05:07 PareshMayani

If we are agree to go ahead with implementing this pattern then in that case we need not to integrate Snackbar.

P.S. I am already done with implementing snackbar with different background colors but haven't sent a PR.

Let's discuss and decide, and please let me know If I should send a PR for snackbar changes!

PareshMayani avatar Jul 22 '15 05:07 PareshMayani

For this kind of blocking case, the empty layout is good. For the other cases, e.g. after having data in cache, the snack-bar is better. Am 22.07.2015 07:52 schrieb "Paresh Mayani" [email protected]:

If we are agree to go ahead with this implementing this pattern then in that case we need not to integrate Snackbar.

P.S. I am already done with implementing snackbar with different background colors but haven't sent a PR.

Let's discuss and decide, and please let me know If I should send a PR for snackbar changes!

— Reply to this email directly or view it on GitHub https://github.com/gdg-x/frisbee/issues/383#issuecomment-123571359.

friedger avatar Jul 22 '15 06:07 friedger

Ok cool. In that case, let's go with the snackbar replacement as of now and close that issue, and will implement the empty layout things later on to resolve this current issue.

What do you say? If agree then should I send a PR for the snackbar implementation? As said, I have replaced all the crouton messages with Snackbar having different background color.

PareshMayani avatar Jul 22 '15 06:07 PareshMayani

I think we already had an open issue for empty space usage. I opened it with the issue about the visual problems with Croutons.

I think we should convert all of Croutons to Snackbars for now. Using the empty spaces issue is not that easy.

@friedger for the cached content, we don't have to show anything at all.

tasomaniac avatar Jul 22 '15 07:07 tasomaniac

You can find the old discussion about this here: https://github.com/gdg-x/frisbee/issues/343

tasomaniac avatar Jul 22 '15 07:07 tasomaniac

This is certainly a better pattern than having all error messages in snackbars.

Splaktar avatar Jul 22 '15 11:07 Splaktar

Also agree that snackbars are appropriate in some cases, so we don't need to remove their implementation completely.

Splaktar avatar Jul 22 '15 11:07 Splaktar

:+1: for keeping snackbar implementation as it wherever a simple message is required.

PareshMayani avatar Jul 22 '15 11:07 PareshMayani

I've assigned this to Release 2.2. Do you all think that this can be done. I think this is important but it is hard as it requires some design in it.

tasomaniac avatar Jul 24 '15 15:07 tasomaniac

I am OK with moving this to 2.3 milestone.

Splaktar avatar Jul 31 '15 01:07 Splaktar

Thanks for modifying the milestone :+1:

PareshMayani avatar Jul 31 '15 06:07 PareshMayani

@PareshMayani If you want to tackle this feel free to assign this task to you again.

friedger avatar Jun 07 '16 21:06 friedger