pyDataverse icon indicating copy to clipboard operation
pyDataverse copied to clipboard

Remove curl dependency

Open skasberger opened this issue 4 years ago • 2 comments

Remove curl dependency from pyDataverse, which is coming from replace_datafile().

Prepare

  • [ ] Test out the issue
  • [ ] Request the problem at IQSS

Implementation

  • [ ] Write tests
  • [ ] Update replace_file()
  • [ ] Update Docs
    • [ ] Homepage
    • [ ] Requirements
  • [ ] Add to release notes
  • [ ] Update Docstrings
  • [ ] Run pytest
  • [ ] Run tox
  • [ ] Run pylint
  • [ ] Run mypy

Review

Follow-Ups

skasberger avatar Feb 15 '21 18:02 skasberger

Would like to upvote this and mention that:

  1. As far as I can tell, it's not replace_datafile, but update_datafile_metadata.
  2. Not only does it cause this dependency, but it makes update_datafile_metadata a strange exception with respect to its return value, which is a CompletedProcess object. So, not only not a Response like everywhere else, but also not "The json string responded by the CURL request, converted to a dict()" as the docstring reads.

bpoldrack avatar Aug 13 '22 14:08 bpoldrack

As discussed during the 2024-02-14 meeting of the pyDataverse working group, we are closing old milestones in favor of a new project board at https://github.com/orgs/gdcc/projects/1 and removing issues (like this one) from those old milestones. Please feel free to join the working group! You can find us at https://py.gdcc.io and https://dataverse.zulipchat.com/#narrow/stream/377090-python

pdurbin avatar Feb 14 '24 20:02 pdurbin