pyDataverse
pyDataverse copied to clipboard
Run pre-commit run --all
As a preparation for the PR for #192, I ran pre-commit run --all and commit the changes to a separate branch now.
This is the result, mostly some changed JSON files and a little bit of black formatting.
All Submissions
Describe your environment
- [ ] OS: macOS, Sonoma 14.5, M1
- [ ] pyDataverse: main branch
- [ ] Python: 3.12
- [ ] Dataverse: 6.3 (see #195)
Follow best practices
- [x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?
- [x] Have you followed the guidelines in our Contribution Guide?
- [x] Have you read the Code of Conduct?
- [x] Do your changes in a seperate branch. Branches MUST have descriptive names.
- [x] Have you merged the latest changes from upstream to your branch?
Describe the PR
- [x] What kind of change does this PR introduce?
- It formats some JSON files, a little bit of Python code and one missing EOL
- [x] Why is this change required? What problem does it solve?
- It is not required, but it makes working with pre-commit a little easier to have a "clean base" – otherwise, future changes might suddenly reformat a while file for minor changes.
- [ ] Screenshots (if appropriate)
- [x] Put
Closes #ISSUE_NUMBERto the end of this pull request
Testing
- [x] Have you used tox and/or pytest for testing the changes? pytest, run-tests.sh
- [x] Did the local testing ran successfully? yes, if changing DV_VERSION to 6.3.
- [ ] Did the Continous Integration testing (Travis-CI) ran successfully?
Commits
- [x] Have descriptive commit messages with a short title (first line).
- [x] Use the commit message template
- [x] Put
Closes #ISSUE_NUMBERin your commit messages to auto-close the issue that it fixes (if such).
Others
- [ ] Is there anything you need from someone else? No.
Code contribution
- [x] Have you used pre-commit? Yes,
pre-commit run --all:) - [x] Have you formatted your code with black prior to submission (e. g. via pre-commit)? yes
- [ ] Have you written new tests for your changes? No
- [ ] Have you ran mypy on your changes successfully? Not attempted
- [ ] Have you documented your update (Docstrings and/or Docs)? No
- [ ] Do your changes require additional changes to the documentation? No
Closes #194
Looks good to me, thanks! Approved.