pyDataverse icon indicating copy to clipboard operation
pyDataverse copied to clipboard

make replace parameter work in edit_dataset_metadata

Open pallinger opened this issue 3 years ago • 6 comments

  • do not delete params in put_request
  • fix replace documentation and parametrization in edit_dataset_metadata

The main problem was that params was overwritten by {} in put_request at the beginning, effectively deleting any parameters passed. This caused the replace parameter in edit_dataset_metadata to not work. There was also some confusion with is_replace in the documentation of edit_dataset_metadata, and also passing boolean instead of string "true" (although that may work, this is more in-line with https://guides.dataverse.org/en/latest/api/native-api.html#edit-dataset-metadata)

  • closes #156

pallinger avatar Jun 16 '22 08:06 pallinger

Could someone review this?

pallinger avatar Aug 09 '22 15:08 pallinger

Update: I left AUSSDA, so my funding for pyDataverse development has stopped.

I want to get some basic funding to implement the most urgent updates (PRs, Bug fixes, maintenance work). If you can support this, please reach out to me. (www.stefankasberger.at). If you have feature requests, the same.

Another option would be, that someone else helps with the development and / or maintenance. For this, also get in touch with me (or comment here).

skasberger avatar Aug 27 '22 08:08 skasberger

@pallinger hi! Is this a fix for the following issue?

  • #156

pdurbin avatar Mar 04 '23 01:03 pdurbin

@pdurbin Yes, it seems to be.

pallinger avatar May 17 '23 11:05 pallinger

Ok, thanks, I added "closes" to the description.

pdurbin avatar May 18 '23 11:05 pdurbin

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

sonarqubecloud[bot] avatar Dec 04 '23 15:12 sonarqubecloud[bot]