gd2910
gd2910
Sorry I've just approved, but on second thought, I think the variable names will be more in line with other code examples as named handlers, eg: `handlePopoverOpen` and `handlePopoverClose`
> The lack of PR description is making it difficult for me to review this. I can see that there's 'showStackblitzBtn' in the new ComponentTesting component, but it's not set...
Will need to pass through Design.
On hold while a11y review on the component is completed. A11y failure - nested interactive (screen readers may not be able access nested content) Need to check if this is...
Giving the ic-section-container a tabindex="0" seems to fix the issue.
Have the new baseline images been generated locally or on the CI?
I'm still concerned about the 5% visual regression threshold increase on each image. The threshold is to take care of font differences between machines, but there is no change in...
I think that the extra threshold is to account for the padding making the canvas height a few pixels larger, this shouldn't be the case if the baseline images used...