julia-snail icon indicating copy to clipboard operation
julia-snail copied to clipboard

Remove `eat-reload` workaround

Open rossviljoen opened this issue 1 year ago • 3 comments

I believe this workaround is no longer necessary after this change.

rossviljoen avatar Aug 07 '24 19:08 rossviljoen

Are you sure? I tried to start Eat with that change, and it still managed to hang in a fresh Emacs session. Eat 0.9.4 from MELPA Stable. Then I put the workaround back in the Eat configuration, and it worked. Then I your change back in, and it worked.

gcv avatar Aug 12 '24 08:08 gcv

Strange, in a fresh emacs 29.4 with the following init.el it works fine (installing Eat 0.9.4 from NonGNU ELPA):

(require 'package)
(when (not package-archive-contents)
    (package-refresh-contents))
(package-initialize)

(use-package eat
  :ensure t
  :pin nongnu
  :custom
  (eat-kill-buffer-on-exit t)
  :config
  (delete [?\C-u] eat-semi-char-non-bound-keys) ; make C-u work in Eat terminals like in normal terminals
  (delete [?\C-g] eat-semi-char-non-bound-keys) ; ditto for C-g
  (eat-update-semi-char-mode-map)
  (eat-reload))

but if it's still an issue feel free to close the PR

rossviljoen avatar Aug 12 '24 19:08 rossviljoen

I just double-checked. After removing the workaround, it looks like Eat does start after a pause, but still does something strange. I get this *Warnings* buffer:

Error (use-package): eat/:config: Lisp nesting exceeds ‘max-lisp-eval-depth’

Do you get this? This happens on Mac and Linux, both running Emacs 29.4.

gcv avatar Aug 16 '24 00:08 gcv

I think the workaround is still needed, please reopen if I’m wrong.

gcv avatar Sep 13 '24 14:09 gcv