musthe icon indicating copy to clipboard operation
musthe copied to clipboard

Another tone notation

Open zsinx6 opened this issue 6 years ago • 5 comments

zsinx6 avatar Jul 17 '18 16:07 zsinx6

@gciruelos can you merge this?

zsinx6 avatar Oct 02 '18 14:10 zsinx6

thank you for pinging me, whenever I don't respond please do

Please remove accents from the note names, let's keep everything in English. Also please give the variables of the new class a better name, because Do Re Mi... are not letters

gciruelos avatar Oct 02 '18 15:10 gciruelos

thank you for pinging me, whenever I don't respond please do

Please remove accents from the note names, let's keep everything in English. Also please give the variables of the new class a better name, because Do Re Mi... are not letters

Since I'm sub classing the Letter class, when renaming the variables, everything must be re-implemented. Or am I missing something?

zsinx6 avatar Oct 02 '18 18:10 zsinx6

Yes, I think in this case refactoring the Letter class might be the easiest.

gciruelos avatar Nov 24 '21 22:11 gciruelos

Please resolve conflicts

gciruelos avatar Mar 24 '24 11:03 gciruelos