cuetools.net icon indicating copy to clipboard operation
cuetools.net copied to clipboard

Fix removing standard custom encoders and decoders

Open DarkVoyage opened this issue 3 years ago • 4 comments

According to changelog this was fixed in 2.2.3. I've tried removing them again and they reappear again. I've already configured needed external encoders and decoders and want to remove these "examples". image

DarkVoyage avatar Feb 21 '23 14:02 DarkVoyage

„Removing of manually added Encoders or Decoders“ has been fixed. See: #201

c72578 avatar Feb 21 '23 16:02 c72578

@DarkVoyage Thanks for your report. The current behavior is unusual concerning deleting of predefined external Encoders or Decoders. Two possibilities:

  • Either gray out (disable) delete for predefined external Encoders or Decoders.
  • Or allow deleting of predefined external Encoders or Decoders and do not let them reappear.

c72578 avatar Feb 22 '23 08:02 c72578

  • Or allow deleting of predefined external Encoders or Decoders and do not let them reappear.

They would reappear if the settings.txt file were ever deleted and a new default settings.txt file created. To expand on the 'gray out' proposal. How about a setting to 'enable' external 'CommandLine' Encoders or Decoders? Users have to supply the .exe to get these to work anyway so why not have them disabled by default and grayed-out in the GUI and advanced settings unless each external Encoder or Decoder is enabled?

{ = "$type": "CUETools.Codecs.CommandLine.EncoderSettings, CUETools.Codecs", = "Name": "flac.exe", = "Extension": "flac", = "Enable": false, <<<<<<<<<< = "Lossless": true, = "SupportedModes": "0 1 2 3 4 5 6 7 8", = "EncoderMode": "5", = "Path": "flac.exe", = "Parameters": "-%M -P %P - -o %O" = },

ha-korth avatar Feb 22 '23 11:02 ha-korth

I don't think it is a big problem to allow removing them completely. If user wants to restore them he can delete settings ini.

DarkVoyage avatar Feb 22 '23 13:02 DarkVoyage