Gaffer icon indicating copy to clipboard operation
Gaffer copied to clipboard

Gh-3094: Allow services to use different cache implementations

Open GCHQDeveloper314 opened this issue 1 year ago • 2 comments

Related issue

  • Resolve #3094

GCHQDeveloper314 avatar Jan 17 '24 16:01 GCHQDeveloper314

Further work is required to add testing for the new multi-cache implementation and to remove as much use of deprecated code as possible, while also adding tests to ensure external code using deprecated methods can still work to some degree.

GCHQDeveloper314 avatar Jan 17 '24 17:01 GCHQDeveloper314

Codecov Report

Attention: Patch coverage is 81.75676% with 27 lines in your changes are missing coverage. Please review.

Project coverage is 66.70%. Comparing base (a8134c9) to head (eede3c9).

Files Patch % Lines
...a/uk/gov/gchq/gaffer/cache/CacheServiceLoader.java 80.43% 6 Missing and 3 partials :warning:
.../src/main/java/uk/gov/gchq/gaffer/store/Store.java 68.96% 6 Missing and 3 partials :warning:
...q/gaffer/federatedstore/FederatedGraphStorage.java 50.00% 3 Missing and 1 partial :warning:
...gov/gchq/gaffer/federatedstore/FederatedStore.java 80.00% 1 Missing and 1 partial :warning:
.../src/main/java/uk/gov/gchq/gaffer/cache/Cache.java 93.75% 1 Missing :warning:
.../src/main/java/uk/gov/gchq/gaffer/graph/Graph.java 0.00% 1 Missing :warning:
...ration/handler/FederatedAddGraphHandlerParent.java 92.85% 0 Missing and 1 partial :warning:
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #3147      +/-   ##
=============================================
+ Coverage      66.34%   66.70%   +0.36%     
- Complexity      2544     2556      +12     
=============================================
  Files            907      907              
  Lines          28975    29063      +88     
  Branches        3216     3239      +23     
=============================================
+ Hits           19223    19387     +164     
+ Misses          8319     8241      -78     
- Partials        1433     1435       +2     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Feb 06 '24 16:02 codecov[bot]