Gaffer icon indicating copy to clipboard operation
Gaffer copied to clipboard

Integration test annotations moved to own class

Open r32575 opened this issue 2 years ago • 1 comments

The TraitRequirement an VisibilityUser annotations are validated or used by the AbstractStoreIT during the validateTraits() and applyVisibilityUser respectively. However, it would be better practice to have separate JUnit extensions and pass the values in as variables before each test method is called rather than handle the annotation logic in the AbstractStoreIT.

r32575 avatar Sep 13 '22 16:09 r32575

Are you suggesting that an extension should replace those methods, or that the annotations should be removed entirely as well?

GCHQDeveloper314 avatar Sep 14 '22 14:09 GCHQDeveloper314