Gaffer icon indicating copy to clipboard operation
Gaffer copied to clipboard

Published 20 hours ago • verified publisher icon gchq

Add CI workflow for legacy Accumulo 1 tests

Open GCHQDeveloper314 opened this issue 2 years ago • 1 comments

Accumulo 2 became the default version of Accumulo in Gaffer in #2679. Accumulo 1 support was retained with a legacy profile.

Currently the CI runs tests for all Maven modules for the default configuration (Accumulo 2). No tests are run with the Accumulo 1 legacy profile. This creates a risk where a PR containing changes which were only compatible with Accumulo 2 might be merged; given that that CI would not detect any problems.

To prevent this from happening, a new GitHub Actions workflow should be added to separately run tests with the Accumulo 1 legacy profile activated. This workflow doesn’t need to run all tests, only tests which involve Accumulo libraries.

GCHQDeveloper314 avatar Jun 29 '22 12:06 GCHQDeveloper314

It would also be nice to test everything against both Java 11 and Java 8.

t92549 avatar Jul 19 '22 14:07 t92549

This would be a new action that would only run the Accumulo store tests, on all PRs but only if changes have been made to the Accumulo store.

lb324567 avatar Nov 09 '22 14:11 lb324567

As the Guava and Hadoop versions differ for Accumulo v1 and v2 it may be best to just run all the tests

r32575 avatar Jan 19 '23 11:01 r32575

Closed by https://github.com/gchq/Gaffer/pull/2894

t92549 avatar Feb 22 '23 12:02 t92549