Gaffer icon indicating copy to clipboard operation
Gaffer copied to clipboard

Add unit tests for integration test suite

Open GCHQDeveloper314 opened this issue 2 years ago • 2 comments

Currently the integration-test module is untested. It defines test classes which are used/extended by various Gaffer stores, but these tests are not tested themselves (unit or integration). Usually tests don't have tests. But in this case integration-test is used as a utility class for other parts of Gaffer and is not simply a traditional test.

Adding some unit tests to integration-test will help to prevent problems caused by other changes from going undetected. Due to how the tests classes are written, there's a potential for tests to become broken without this being detected. This is because if the tests do not run or are skipped then it will appear from the CI that there's no problem.

GCHQDeveloper314 avatar May 24 '22 08:05 GCHQDeveloper314

@GCHQDeveloper314 How big a piece of work is this?

n3101 avatar Jun 01 '22 11:06 n3101

This is small piece of work. I would anticipate only a couple of new files containing some basic Unit tests.

GCHQDeveloper314 avatar Jun 06 '22 08:06 GCHQDeveloper314

Fixed by #2732

lb324567 avatar Oct 19 '22 12:10 lb324567