gh-2457 double caching issue

[GCHQDev404]

Related Issue

• Resolve #2457

[codecov-commenter]

Codecov Report

:exclamation: No coverage uploaded for pull request base (v2-alpha@cb73779). Click here to learn what that means. The diff coverage is n/a.

@@             Coverage Diff             @@
##             v2-alpha    #2595   +/-   ##
===========================================
  Coverage            ?   55.09%           
  Complexity          ?     2490           
===========================================
  Files               ?      814           
  Lines               ?    28314           
  Branches            ?     2881           
===========================================
  Hits                ?    15599           
  Misses              ?    11486           
  Partials            ?     1229           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[GCHQDev404]

blocked by #2769

[GCHQDev404]

I can see quite a few comments of TODO FS. Could it be clarified if this PR is ready for merge? Some of the comment do look like they can be addressed later. Instead of leaving these comments in the code, a follow up issue could be raised - especially for the comments in the tests.

These are left in for when I'm showing team the code. It's so people know what I'm thinking and where I'm thinking it, before a ticket is made. Most of these TODOs will be addressed during Alpha stages. The comments do not affect reviewing of code.