Gaffer icon indicating copy to clipboard operation
Gaffer copied to clipboard

GetWalks operation does not accept GetElementsBetweenSets operations

Open d21211122 opened this issue 6 years ago • 3 comments

It would be useful if you could perform a 'GetWalksBetweenSets'. This could be achieved by allowing a GetElementsBetweenSets operation as part of a GetWalks, but only GetElements operations are currently supported.

d21211122 avatar Oct 24 '18 09:10 d21211122

I've been having a go at this, and have added the GetElementsBetweenSets to the 'if' clauses in GetWalks.java, and written the relevant tests, and all seems to work correctly (GetWalksTest.java all pass). However, upon running the mvn clean install build, I get errors stating that the package uk.gov.gchq.gaffer.accumulostore.operation.impl does not exist. I'm guessing this is down to cyclical/circular dependencies? Any suggestions on how to resolve?

g609bmsma avatar Mar 01 '19 11:03 g609bmsma

Hi @g609bmsma. So Having a think about this we have 2 options that I can think of. Move the GetElementsBetweenSets Op to the store package, or we implement our own GetWalks handler within the Accumulo Store. I think Logically it makes more sense to implement the latter, and implement a new handler which will be the same as the updated one with your code in but in the Accumulo store package. Then tests will need to be added for this using GetElements and GetElementsBetweenSets.

m55624 avatar Mar 08 '19 11:03 m55624

ok I was tempted. This might be salvageable, but doesn't have to be in 2.0

n3101 avatar Feb 02 '22 17:02 n3101