Gaffer
Gaffer copied to clipboard
GetWalks operation does not accept GetElementsBetweenSets operations
It would be useful if you could perform a 'GetWalksBetweenSets'. This could be achieved by allowing a GetElementsBetweenSets operation as part of a GetWalks, but only GetElements operations are currently supported.
I've been having a go at this, and have added the GetElementsBetweenSets
to the 'if' clauses in GetWalks.java
, and written the relevant tests, and all seems to work correctly (GetWalksTest.java
all pass). However, upon running the mvn clean install
build, I get errors stating that the package uk.gov.gchq.gaffer.accumulostore.operation.impl does not exist. I'm guessing this is down to cyclical/circular dependencies? Any suggestions on how to resolve?
Hi @g609bmsma. So Having a think about this we have 2 options that I can think of. Move the GetElementsBetweenSets Op to the store package, or we implement our own GetWalks handler within the Accumulo Store. I think Logically it makes more sense to implement the latter, and implement a new handler which will be the same as the updated one with your code in but in the Accumulo store package. Then tests will need to be added for this using GetElements and GetElementsBetweenSets.
ok I was tempted. This might be salvageable, but doesn't have to be in 2.0