CyberChef icon indicating copy to clipboard operation
CyberChef copied to clipboard

Added 2 new operations 'NTPTimestampToUNIXTimestamp' and 'UNIXTimesta…

Open kossithedon opened this issue 1 year ago • 4 comments

Hello,

I'm adding 2 new operations to convert NTP timestamp to UNIX timestamp and the other way round. The NTP timestamp is detailed in the following links :

https://www.ntp.org/reflib/y2k/ https://datatracker.ietf.org/doc/html/rfc5905 https://tickelton.gitlab.io/articles/ntp-timestamps/

kossithedon avatar May 18 '24 22:05 kossithedon

Failed on UI tests. Can you fix it or do i need to made modifications to the operations code ?

kossithedon avatar May 19 '24 00:05 kossithedon

Hello,

Any news on this ?

kossithedon avatar Jun 05 '24 22:06 kossithedon

Hey @KossiJunior, this is a really good PR and a nice addition to CyberChef! Could you add the tests you've created to the test runner in this file:

https://github.com/gchq/CyberChef/blob/master/tests/operations/index.mjs

Other than that, your PR looks ready to go!

a3957273 avatar Jun 11 '24 21:06 a3957273

It should be good.

kossithedon avatar Jun 12 '24 23:06 kossithedon