CyberChef icon indicating copy to clipboard operation
CyberChef copied to clipboard

Introduce Yubico's Modhex for Conversion

Open linuxgemini opened this issue 5 years ago • 6 comments

Mod(ified)hex is Yubico's implementation for somewhat universal OTP entry from a single security key, regardless of keyboard layout (with few exceptions).

This PR implements basic conversion functionality by mapping the characters into hex and converting it back and forth.

Some information is available here: https://en.wikipedia.org/wiki/YubiKey#ModHex

linuxgemini avatar Sep 19 '20 13:09 linuxgemini

Signed-off-by: İlteriş Yağıztegin Eroğlu [email protected]

linuxgemini avatar Feb 13 '21 12:02 linuxgemini

Are there any updates on the merging of this PR?

linuxgemini avatar May 04 '21 10:05 linuxgemini

Hey! This pull request has gotten rather old and that's our fault. This project stopped being actively maintained for a while and it looks like your pull request has started to gather dust. Would you be able to update your branch to the latest version of CyberChef and we'll give it a review?

a3957273 avatar Jun 11 '24 22:06 a3957273

Hey! This pull request has gotten rather old and that's our fault. This project stopped being actively maintained for a while and it looks like your pull request has started to gather dust. Would you be able to update your branch to the latest version of CyberChef and we'll give it a review?

Heya! It sure did get dust 😅, I'll try re{bas,factor}ing the code to current CyberChef later today (June 12th). Will poke when its done.

linuxgemini avatar Jun 12 '24 00:06 linuxgemini

@a3957273 I think this should do it, I couldn't get tests working on macOS; so tests may or may not work.

linuxgemini avatar Jun 12 '24 11:06 linuxgemini

@a3957273 Hi again! Turns out I had some issues in the lib file, the test errors doesn't reflect anything back so it took me a while (perhaps improving test outputs would be a roadmap item?). This one (edd22372) should pass the tests.

Post test edit: Looks like UI tests failed, but the lib passed.

linuxgemini avatar Jun 18 '24 00:06 linuxgemini

Looks good to me, hopeful to merge. Just trying to resolve the CI issues causing failing UI tests.

a3957273 avatar Feb 16 '25 02:02 a3957273

Thanks for the contribution! :)

a3957273 avatar Feb 16 '25 02:02 a3957273

Thank you!

linuxgemini avatar Feb 16 '25 03:02 linuxgemini