sysrsync
sysrsync copied to clipboard
Inconsistent use of Type Hints
I noticed that there is an inconsistent use of Type Hits within this program.
Some modules and functions have type hints in place, others do not.
Specifically, the run command doesn't have type hints, while many of the other commands do.
https://github.com/gchamon/sysrsync/blob/c978be1f0e0a0a7d3451fce11c615c571c9f2a1d/sysrsync/runner.py#L9
Have you considered adding type hints?
I should have typed the run return value to being subprocess.Process, if my memory serves me right. I could try typing the arguments, but I think it will be challenging for **kwargs
**kwargs can be one of the expected types, or Union[type1, type2, ...] if we go deep with the typing library. Just a thought ;)
thanks =D and thanks for the interest in the project. I will revise the typing in the project as soon as possible
better late than never. On it