sysrsync icon indicating copy to clipboard operation
sysrsync copied to clipboard

Inconsistent use of Type Hints

Open teward opened this issue 5 years ago • 4 comments

I noticed that there is an inconsistent use of Type Hits within this program.

Some modules and functions have type hints in place, others do not.

Specifically, the run command doesn't have type hints, while many of the other commands do.

https://github.com/gchamon/sysrsync/blob/c978be1f0e0a0a7d3451fce11c615c571c9f2a1d/sysrsync/runner.py#L9

Have you considered adding type hints?

teward avatar Dec 10 '19 04:12 teward

I should have typed the run return value to being subprocess.Process, if my memory serves me right. I could try typing the arguments, but I think it will be challenging for **kwargs

gchamon avatar Dec 11 '19 13:12 gchamon

**kwargs can be one of the expected types, or Union[type1, type2, ...] if we go deep with the typing library. Just a thought ;)

teward avatar Dec 11 '19 13:12 teward

thanks =D and thanks for the interest in the project. I will revise the typing in the project as soon as possible

gchamon avatar Dec 11 '19 14:12 gchamon

better late than never. On it

gchamon avatar May 08 '21 00:05 gchamon