fp-ts-rxjs
fp-ts-rxjs copied to clipboard
gcanti
replace deprecated tslint
The project is currently pinned to rxjs 6 because rxjs 7 requires TS 4.2. The problem is that tslint-config-standard enforces TS 3.3
https://github.com/blakeembrey/tslint-config-standard/blob/6968884cb55070bffc3dacb9e6a147aecb639f84/package.json#L67
To get rid of the deprecated tslint and tslint-config-standard packages we can replace it by eslint-config-standard-with-typescript which is based on the eslint-config-standard and suggested in https://github.com/blakeembrey/tslint-config-standard/issues/61
An ESLint shareable config for TypeScript that is based on eslint-config-standard and has TypeScript specific rules from @typescript-eslint/eslint-plugin.
First step to solve #63
The project is currently pinned to rxjs 6 because rxjs 7 requires TS 4.2. The problem is that tslint-config-standard enforces TS 3.3
This is just a dev dependency and does not enforce a certain TypeScript version on the fp-ts-rxjs project. If you want to add support rxjs 7 you should be able to update typescript without any problems.
Hm, maybe i misunderstand something here…
When i try to update the TS version to match the required version of rxjs npm throws the following error message
$ npm install --save-dev [email protected]
....
npm ERR! Could not resolve dependency:
npm ERR! peer typescript@"^2.2.0 || ^3.0.0" from [email protected]
npm ERR! node_modules/tslint-eslint-rules
npm ERR! tslint-eslint-rules@"^5.3.1" from [email protected]
npm ERR! node_modules/tslint-config-standard
npm ERR! dev tslint-config-standard@"^8.0.1" from the root project
But with rxjs 7 and without TS >=4.2 this project can't be build
$ tsc -p ./tsconfig.build.json && tsc -p ./tsconfig.build-es6.json && npm run import-path-rewrite && ts-node scripts/build
…
Found 58 errors.
@mlegenhausen After giving it a shot, @albohlabs has the right of it. Far as I can tell this does seem like a hard block to upgrading to rxjs 7.
Hello! I would also like to integrate fp-ts and rxjs, but i am using rxjs@7. So i am voting for merging it:)
I need this too ! Is there any blocker ? This PR seems to be ready for a year now …
