fp-ts-rxjs icon indicating copy to clipboard operation
fp-ts-rxjs copied to clipboard

Published 20 hours ago • verified publisher icon gcanti

Replace mergemap with switchmap

Open raveclassic opened this issue 4 years ago • 4 comments

This PR replaces mergeMap with switchMap to avoid memory leaks.

contains parts of https://github.com/gcanti/fp-ts-rxjs/pull/29

closes #27

raveclassic avatar Apr 08 '20 16:04 raveclassic

Ok, got it, I'll update the PR.

raveclassic avatar Jun 10 '20 06:06 raveclassic

How did we go on this one? Switch map is important.

Otherwise I may have to maintain a patched version of this repo if I am to use chain in projects.

If there is anything pending for gcanti's proposal of changes, what are they? I'd be happy to lend a hand.

waynevanson avatar Oct 02 '20 12:10 waynevanson

I know bumping github issues and PRs is bad form, but I also think switchMap really is important. chain is a core function, used by many other pipeable functions, and I'm finding it rather impractical to maintain my own versions so that I can have switchMap behaviour.

If nobody's willing to move this PR forward, should we create another simpler PR for the use of switchMap?

wmaurer avatar Apr 21 '21 13:04 wmaurer

OK, let's see what happens, new PR here: https://github.com/gcanti/fp-ts-rxjs/pull/60

wmaurer avatar Apr 21 '21 19:04 wmaurer