pychess-variants icon indicating copy to clipboard operation
pychess-variants copied to clipboard

Add cburnett pieces to Makruk

Open Rechefiltr-is-Fire opened this issue 2 years ago • 9 comments

I even made Silver in Keynote from basic pieces, drawings, but based on part of cburnett bishop.

Rechefiltr-is-Fire avatar Aug 11 '22 22:08 Rechefiltr-is-Fire

My thoughts

  1. I would like to see a full board screenshot to judge how it looks in real gameplay.
  2. You should probably add this set to Sittuyin and ASEAN too. Especially ASEAN.
  3. There's a rogue file at pieces/bS.svg. You should delete it.

Fulmene avatar Aug 13 '22 17:08 Fulmene

@Fulmene See https://github.com/gbtami/pychess-variants/issues/990 to understand. So don’t use small SVGs, so it’s better to resize SVGs from the issue #990 because small white silver will conflict with other
MAKRUKMEN🧄

Rechefiltr-is-Fire avatar Aug 13 '22 18:08 Rechefiltr-is-Fire

  1. Please don't create a whole new issue for this. Just reply here.
  2. The tips of the khon pieces look unusually grey. I think it should be more white.
  3. The white lines on the black piece is too large. It should be in similar style with the queen. The bottom line should be removed.

Fulmene avatar Aug 14 '22 09:08 Fulmene

OK!!!

Rechefiltr-is-Fire avatar Aug 14 '22 14:08 Rechefiltr-is-Fire

Please don't embed pixel images into .svg when the image itself is simple and can be drawn in Inkscape.

gbtami avatar Aug 14 '22 15:08 gbtami

What should I do?;)

Rechefiltr-is-Fire avatar Aug 14 '22 17:08 Rechefiltr-is-Fire

Draw it as vector graphics (.svg) instead of pixel graphics (.png).

gbtami avatar Aug 14 '22 19:08 gbtami

I haven’t Inkscape! So it’s svgs wS bS Resize it pls.

Rechefiltr-is-Fire avatar Aug 14 '22 19:08 Rechefiltr-is-Fire

To understand what I'm talking about read https://xd.adobe.com/ideas/principles/app-design/bitmap-vs-vector-images-difference/ please.

gbtami avatar Aug 14 '22 20:08 gbtami

It’s SVGs already!!!!!!!! So please resize it as shown in https://xd.adobe.com/ideas/principles/app-design/bitmap-vs-vector-images-difference/ without quality loss. It’s already SVGs, do Û hear me? 🤣 Site when it converted to vector — Aconvert

Rechefiltr-is-Fire avatar Aug 16 '22 09:08 Rechefiltr-is-Fire

No. If you look into your .svg files in Edit mode https://github.com/Rechefiltr-is-Fire/pychess-variants/edit/patch-7/static/images/pieces/green/bS.svg?pr=%2Fgbtami%2Fpychess-variants%2Fpull%2F989 you will see it is just an embedded (base64 encoded) .pgn inside the .svg file.

Real vector graphics contains xml tags and attributes describing the lines, curves, colors, paths in textual format. Here is an example https://github.com/gbtami/pychess-variants/edit/master/static/images/pieces/merida/bF.svg

gbtami avatar Aug 16 '22 10:08 gbtami

Hah bro, that I mean SVGs in pull request and closed issue, not small SVGs in my repository. Small SVGs are losing quality, alright.

Rechefiltr-is-Fire avatar Aug 16 '22 12:08 Rechefiltr-is-Fire

When you fix Fulmene issues 2. and 3. above and recreate the pieces in vector graphics format (not as embedded pixel images) we can add them for sure. Until then I close this.

gbtami avatar Oct 04 '22 09:10 gbtami