pychess-variants
pychess-variants copied to clipboard
Add cburnett pieces to Makruk
I even made Silver in Keynote from basic pieces, drawings, but based on part of cburnett bishop.
My thoughts
- I would like to see a full board screenshot to judge how it looks in real gameplay.
- You should probably add this set to Sittuyin and ASEAN too. Especially ASEAN.
- There's a rogue file at
pieces/bS.svg
. You should delete it.
@Fulmene See https://github.com/gbtami/pychess-variants/issues/990 to understand.
So don’t use small SVGs, so it’s better to resize SVGs from the issue #990 because small white silver will conflict with other
MAKRUKMEN🧄
- Please don't create a whole new issue for this. Just reply here.
- The tips of the khon pieces look unusually grey. I think it should be more white.
- The white lines on the black piece is too large. It should be in similar style with the queen. The bottom line should be removed.
OK!!!
Please don't embed pixel images into .svg when the image itself is simple and can be drawn in Inkscape.
What should I do?;)
Draw it as vector graphics (.svg) instead of pixel graphics (.png).
I haven’t Inkscape!
So it’s svgs
Resize it pls.
To understand what I'm talking about read https://xd.adobe.com/ideas/principles/app-design/bitmap-vs-vector-images-difference/ please.
It’s SVGs already!!!!!!!! So please resize it as shown in https://xd.adobe.com/ideas/principles/app-design/bitmap-vs-vector-images-difference/ without quality loss. It’s already SVGs, do Û hear me? 🤣 Site when it converted to vector — Aconvert
No. If you look into your .svg files in Edit mode https://github.com/Rechefiltr-is-Fire/pychess-variants/edit/patch-7/static/images/pieces/green/bS.svg?pr=%2Fgbtami%2Fpychess-variants%2Fpull%2F989 you will see it is just an embedded (base64 encoded) .pgn inside the .svg file.
Real vector graphics contains xml tags and attributes describing the lines, curves, colors, paths in textual format. Here is an example https://github.com/gbtami/pychess-variants/edit/master/static/images/pieces/merida/bF.svg
Hah bro, that I mean SVGs in pull request and closed issue, not small SVGs in my repository. Small SVGs are losing quality, alright.
When you fix Fulmene issues 2. and 3. above and recreate the pieces in vector graphics format (not as embedded pixel images) we can add them for sure. Until then I close this.