pychess-variants
pychess-variants copied to clipboard
Joyful for Makruk (not required to add; required to watch)
If someone of your helpers will like. Not required to add now. So you don’t want to add fun pieces. It isn’t fun, it’s joy! https://github.com/lichess-org/lila/issues/11061
First of all thx for creating PR to share your work! Here are my notes.
- As I see you embed pixel images into .svg This is not needed. We prefer .svg pieces (because they scale well), but chessground supports .png/.jpeg piece images as well. (Example: https://github.com/gbtami/pychess-variants/blob/master/static/piece/standard/santa.css)
- Piece design should be consistent. The knights are absolutely off regarding style. They are kid drawing by hand. I mean all the other pieces uses geometric shapes and outlined by strong cover, except the knight. I suggest to read tomato's blog about piece design https://lichess.org/@/CouchTomato87/blog/designing-internationalized-pieces-for-eastern-forms-of-chess/il0bp2Hi
So it’s all svgs. But I can’t remake knight. I haven’t form of cucumber or squash in Keynote. P.S. The knight model which you see is oldest piece model with minimal changes.
If you can recreate the pieces in vector graphics format (not as embedded pixel images) we can consider to add them. Until then I close this.