pychess-variants icon indicating copy to clipboard operation
pychess-variants copied to clipboard

Joyful for Makruk (not required to add; required to watch)

Open Rechefiltr-is-Fire opened this issue 3 years ago • 2 comments

If someone of your helpers will like. Not required to add now. So you don’t want to add fun pieces. It isn’t fun, it’s joy! https://github.com/lichess-org/lila/issues/11061

Rechefiltr-is-Fire avatar Jun 27 '22 12:06 Rechefiltr-is-Fire

First of all thx for creating PR to share your work! Here are my notes.

  1. As I see you embed pixel images into .svg This is not needed. We prefer .svg pieces (because they scale well), but chessground supports .png/.jpeg piece images as well. (Example: https://github.com/gbtami/pychess-variants/blob/master/static/piece/standard/santa.css)
  2. Piece design should be consistent. The knights are absolutely off regarding style. They are kid drawing by hand. I mean all the other pieces uses geometric shapes and outlined by strong cover, except the knight. I suggest to read tomato's blog about piece design https://lichess.org/@/CouchTomato87/blog/designing-internationalized-pieces-for-eastern-forms-of-chess/il0bp2Hi

gbtami avatar Jun 29 '22 08:06 gbtami

So it’s all svgs. But I can’t remake knight. I haven’t form of cucumber or squash in Keynote. P.S. The knight model which you see is oldest piece model with minimal changes.

Rechefiltr-is-Fire avatar Jul 05 '22 08:07 Rechefiltr-is-Fire

If you can recreate the pieces in vector graphics format (not as embedded pixel images) we can consider to add them. Until then I close this.

gbtami avatar Oct 04 '22 09:10 gbtami