grizli icon indicating copy to clipboard operation
grizli copied to clipboard

Dispersive element naming confusion

Open victoriastrait opened this issue 3 years ago • 1 comments

It's confusing that the dispersive element for HST, NIRISS, and NIRCam are all different. Maybe call dispersive element dispname throughout, which will be FILTER for HST, PUPIL-FILTER for NIRISS and FILTER-PUPIL for NIRCam, with a function in utils that generates this from a passed Header or ImageHDU

victoriastrait avatar May 24 '22 09:05 victoriastrait

I think that this is now essentially fixed in that utils.get_hst_filter returns the combination {filter}-{disperser} for JWST instruments accounting for the swap between NIRCam and NIRISS WFSS.

However, pipeline.auto_script.load_GroupFLT still doesn't recognize two JWST grisms for a common blocking filter as being processed together.

gbrammer avatar Jun 08 '22 13:06 gbrammer