Gabe Brammer

Results 60 comments of Gabe Brammer

I think the preferred fix would be to modernize the auto_script script to use the new code to make the mosaics and combined images. That should solve the file name...

@mcara, my change does nothing but accept and pass around an `astropy.wcs.WCS` object as a parameter rather than generating it on-the-fly from a header. I should say, for exactly the...

Ok, I see @mcara. I didn't update the Changelog, so I'm not sure what that is referring to. The only place where my PR actually does anything is [here](https://github.com/gbrammer/pyregion/blob/46edfe803908b9e5acc8e373c3c28f9bd8434a91/pyregion/wcs_converter.py#L81). I...

Thanks for sending this. I can't reproduce the error using the provided catalog, which could be due to differences in machine architecture and floating point precision. It's definitely worrisome that...

@nallen98 , can you please close this issue if the fix above solved it? Thanks!

Finally getting around to this. Could you rename the parameter controlling whether to output the context image `out_ctx` to `write_context`? And for the issue with more than 32 images, how...

Looking good. - There seems to still be one commented block in `aws_drizzler` - Can you rename `ctx_out` to something a bit more meaningful (e.g., `write_ctx_file`, `write_context`)

Yes, that sounds like a good idea. The peakutils bits aren't particularly sophisticated, and are probably easily replaced with something like you mention.

Cool. If it's actually even the same algorithm that would be ideal. One useful bit I use from peakutils is the way it can find peaks with a user-specified minimum...

Yes, I think it should be fine to add CI test builds for the newer versions. I generally use 3.10 myself.