jquery_pagination icon indicating copy to clipboard operation
jquery_pagination copied to clipboard

link_to : '#' is a bad default

Open rizen opened this issue 13 years ago • 3 comments

I'd like to make a recommendation that the default link_to be 'javascript:void(0)' rather than '#'. There are two reasons for this:

  1. '#' actually causes the page to scroll

  2. If you're using jQuery pagination with a URL fragment writer like jQuery BBQ then it overwrites the fragment with just '#', which can be difficult to debug to understand why that is happening.

If you decide not to do this (which I understand), then I'd recommend adding a note in the docs for users to set it to 'javascript:void(0)' when doing URL fragment rewriting.

Anyway, thanks for an amazing pagingator! Oh, and per your request at the bottom of the docs, I'll be using jQuery pagination on sirishouldsay.com and probably eventually on thegamecrafter.com.

rizen avatar Nov 14 '11 02:11 rizen

+1 to this issue. I never complained about it, but I already had problem with this.

iurisilvio avatar Nov 14 '11 13:11 iurisilvio

christ,I have a problem with hash set,for two days .finally. thanks guys.

IEfucker avatar Mar 28 '13 10:03 IEfucker

I've created a pull request for this https://github.com/gbirke/jquery_pagination/pull/47

vctr-dev avatar Jul 14 '17 00:07 vctr-dev