pygbif icon indicating copy to clipboard operation
pygbif copied to clipboard

Testing: tox

Open niconoe opened this issue 5 years ago • 3 comments

I noticed that it seems tox testing has been added a long time ago via: https://github.com/sckott/pygbif/pull/20, a nice addition IMHO.

Is it still in use? If no, I suggest some cleanup (tox.ini for example). If yes, I think we could make some improvements:

  • Document tox's use in contributor's documentation
  • Make sure tox environments (configured in tox.ini match the supported Python version - it's currently 2.7 and 3.4)
  • See if can combine tox and Travic-CI: the aim would be to have a single configuration point, and allow testing all environments both locally and on Travis-CI.

Hope this helps!

niconoe avatar May 26 '20 08:05 niconoe

I haven't been using tox myself. I run tests with make test, using nose.

I'd be happy to try tox, can you propose changes to the file?

sckott avatar May 26 '20 16:05 sckott

Yeah, I'd be happy to contribute that! Don't hesitate to assign me to this issue (I can't do it myself) so there's some hope I don't forget about it :)

niconoe avatar May 28 '20 08:05 niconoe

I've assigned you

sckott avatar May 28 '20 13:05 sckott