Tests fail on github release archive

[mid-kid]

Steps to reproduce:

wget https://github.com/gbdev/rgbds/releases/download/v0.5.2/rgbds-0.5.2.tar.gz
tar xf rgbds-0.5.2.tar.gz
cd rgbds
make
cd test/fix
./test.sh

Errors appear, like:

/home/mid-kid/rgbds/test/fix/version.gb out.gb differ: char 333, line 3
./test.sh: ./gbdiff.bash: /bin/bash^M: bad interpreter: No such file or directory

How to fix in repo:

for x in contrib/gbdiff.bash test/fix/*.flags; do
  cat "$x" | tr -d '\r' > tmp; cat tmp > "$x"; rm tmp
done

Though it probably should be fixed in gitattributes.

[ISSOtm]

I guess the fix would be to disable auto-CRLF in our CI script, as well as re-generating all affected tarballs.

[mid-kid]

Regenerating tarballs after this long is kinda evil since most packaging scripts rely on it staying the same for verification. And failing tests is super minor. But if you want a list, it's just 0.5.1 and 0.5.2.

[mid-kid]

Also why not fix the gitattributes?

[ISSOtm]

Because it appears to work fine on Windows installs despite using CRLF, if I am to believe our CI.

[ISSOtm]

As for regenerating the tarballs, you're right.

[Rangi42]

I think e35585960c5b814a00e216fdc6f7fa1503134250 and 830df360ae7dd5f045d177c5bc57746a9a6d337e resolved this too. Edit: Nope, the reported problems still occur with rgbds-0.6.0-rc2.tar.gz.