rgbds-live icon indicating copy to clipboard operation
rgbds-live copied to clipboard
verified publisher icon gbdev

Dark mode

Open avivace opened this issue 1 year ago • 4 comments

Current progress:

  • [x] Support dark mode (#37)
  • [ ] Support manually setting a colour theme
  • [ ] Keep track of the manually-selected theme across sessions

avivace avatar Sep 16 '24 14:09 avivace

https://github.com/gbdev/rgbds-live/pull/37 will do that theme is based on syste/browser settings

you can check how it looks for both themes fx in chrome devtools via Rendering tab image

image

SelvinPL avatar Sep 16 '24 19:09 SelvinPL

dark

image

light

image

SelvinPL avatar Sep 16 '24 19:09 SelvinPL

hmmm https://selvin.pl/rgbds-live/ has now selector for themes but i do not save them ... also not all themes looks goos as this is palette for ace and it's hard to choose from

SelvinPL avatar Sep 17 '24 15:09 SelvinPL

I edited the OP to keep track of the sub-features. A PR for the second one can be opened, now that #37 has been merged?

As for the third one, I'd guess “check if a preference is set in localStorage; if not, set it to a default based on the system theme” should work?

ISSOtm avatar Sep 18 '24 17:09 ISSOtm