database icon indicating copy to clipboard operation
database copied to clipboard

File->"Playable" should be true by default/if the value is absent

Open avivace opened this issue 1 year ago • 3 comments

avivace avatar Jun 06 '24 23:06 avivace

can we assume every entry in the database has at least one gb/gbc/gba playable file?

dag7dev avatar Oct 17 '24 09:10 dag7dev

can we assume every entry in the database has at least one gb/gbc/gba playable file?

nope not really, there are some metadata-only entries. I'm not sure what this issue was about lol

avivace avatar Oct 17 '24 09:10 avivace

I'm not sure what this issue was about lol

I remember an issue like that some time ago too.

Anyway, this leads in some complications:

  1. we cannot assume that every entry in the database has at least one playable file
  2. we cannot assume that the first file in the "files" array is the most up-to-date version (we may have contributors that has put most recent entry file at the end and not beginning)

Therefore, i'd edit this issue with "add a playable field to AT LEAST one playable file, if not present".

The work should be something like:

  1. scan every json
  2. if "playable: true" is present and the file is a gb/gbc/gba whatever playable file, good
  3. if not, then add it to the first occurrence

We still have the second problem (not most up-to-date guaranteed), but at least we have the guarantee that each file is listed and playable.

I don't remember if this check already occurs at a certain point in the pipeline...

dag7dev avatar Oct 17 '24 09:10 dag7dev