go-verkle icon indicating copy to clipboard operation
go-verkle copied to clipboard

Avoid panics

Open jsign opened this issue 2 years ago • 1 comments

Do a full-scan of the repository to avoid explicit panics. Even though we usually use them in cases where critical invariants must hold, panicking is very aggressive for at least a graceful shutdown, even in non-recoverable errors.

Also, scan for dependencies (e.g: go-ipa) for the same.

We can do this getting closer to a stable implementation, and definitely before getting close to being fully integrated in geth since it can result in breaking some APIs returning errors instead of panicking.

cc @gballet

jsign avatar May 02 '23 13:05 jsign

Yeah that's too many

~/s/go-verkle (master)> grep -r panic * | wc -l
29

gballet avatar Jun 16 '23 08:06 gballet