deluge-seedtime icon indicating copy to clipboard operation
deluge-seedtime copied to clipboard

Initial seedtime limit based on tracker or label

Open vanossj opened this issue 9 years ago • 13 comments

I added a support for setting the initial seedtime limit based on tracker or label. The user can set up a table of regex filters in the gtkui.

preferencesscreen

I would have liked to add all filter code to post_torrent_add hook, but I could not see a way to guarantee that the label post_torrent_add hook would be processed first. So instead I deferred the call by 1 second.

Suggestions welcome

vanossj avatar Mar 17 '15 18:03 vanossj

Hi this is great work and exactly what I need... how do I implement it?

Symbiot78 avatar Mar 24 '16 05:03 Symbiot78

Can you clarify what you mean by 'implement it'? Do you want to build the plugin? install it? use the plugin?

vanossj avatar Mar 24 '16 12:03 vanossj

Hi

I really just want to use it :-) I tried building it and I MIGHT have it installed.. but I am unsure on the proper usage.. perhaps if you gave a short usage guide I can give it a go :-)

Symbiot78 avatar Mar 24 '16 13:03 Symbiot78

Ok, been playing a little with what I think is your build.. I created a label called 'test'. I set the field to "label" & Filter to "test" & seedtime to 0.. but when the torrent is added is it given a 3 day seedtime no matter what.. I cannot set a label when the torrent is loaded so I am thinking it sets the default seed time rule and then doesn't change it ?

1 2

Symbiot78 avatar Mar 24 '16 14:03 Symbiot78

oh this is for manually added torrents.. I haven't tested on autoadded torrents..

Symbiot78 avatar Mar 24 '16 14:03 Symbiot78

Ok, it works for autoadded torrents :-)

Symbiot78 avatar Mar 24 '16 14:03 Symbiot78

I updated my README and added a release, but it looks like you've gotten that far already.

The seed time is filters on information available when a torrent is added, manually or automatically. Filtering on tracker works all the time because that information is always there when a torrent is added. The caveat for label filters is that there is not a way to specify a label when adding a torrent manually via the gui. So these torrents don't yet have a label when added and that's why they are falling through to the default filter.

There are some possibly workarounds. The plugin could wait 1 minute before assigning a seed time. This way, if you changed the label right after you add the torrent, the seedtime filters would see that label and assign the expected stopping time

vanossj avatar Mar 24 '16 14:03 vanossj

Hi setting a delay would be pretty good.. a few minutes.. or even better... the OPTION to set a delay manually in the plugin.. I set up a simple seedtime filter as in the picture.. I sorted it by importance and used both label & tracker to split torrents that have different labels but can potentially be from the same tracker..

see screenshot.. 3

Symbiot78 avatar Mar 24 '16 15:03 Symbiot78

Could the plugin also be updated so in main view under the column "stop seed time" you could actually see the remaining seed time before 'seedtime' plugin removes the torrent? it only shows the initial time and doesn't change..

Symbiot78 avatar Mar 25 '16 06:03 Symbiot78

added the configurable delay.

There is already "stop seed time" and a "seeding time" columns, a remaining seed time would just be the difference between the two. Would you use a "remaining seed time" column instead of the other two? Trying to strike a balance between useful options and too many options.

vanossj avatar Mar 26 '16 20:03 vanossj

Hi

Great work.. will be testing soon.. !

I'd personally prefer to have a "remaining seed time" column since all my torrent are using the 'seedtime' plugin. Just having a static column like it is now is of no use.. only thing you can use if for is to verify that the seedtime has been set.. which would be apparent if the 'remaining seedtime' column is present. I assume you would be able to 'just' add the column and let the user choose? I'm not a programmer so I haven't got a clue as to the level of difficulty in doing this..

I would think it a great feature to add to the plugin ..

Symbiot78 avatar Mar 26 '16 21:03 Symbiot78

There you go

vanossj avatar Mar 27 '16 15:03 vanossj

This is versuching fantastic..! great work Vanossj...! The seedtime plugin just got way way way more useful to me... I hope more people will find this plugin!!

seedtime

Symbiot78 avatar Mar 27 '16 18:03 Symbiot78